Skip to content

Cleanup type ignores in vertica provider where possible#53252

Merged
gopidesupavan merged 2 commits intoapache:mainfrom
jscheffl:bugfix/cleanup-mypy-vertica
Jul 13, 2025
Merged

Cleanup type ignores in vertica provider where possible#53252
gopidesupavan merged 2 commits intoapache:mainfrom
jscheffl:bugfix/cleanup-mypy-vertica

Conversation

@jscheffl
Copy link
Contributor

Relates to #53241

@jscheffl jscheffl force-pushed the bugfix/cleanup-mypy-vertica branch from 112438b to de0c217 Compare July 13, 2025 08:27
@gopidesupavan gopidesupavan merged commit 8fb8de2 into apache:main Jul 13, 2025
133 of 134 checks passed
@kyungjunleeme
Copy link
Contributor

#53311

this case same case

        """Establish a connection to pinot broker through pinot dbapi."""
        conn = self.get_connection(self.pinot_broker_conn_id)  # type: ignore
        """Establish a connection to pinot broker through pinot dbapi."""
        conn = self.get_connection(self.get_conn_id())

get_conn_id() is a method defined in DbApiHook that dynamically returns the appropriate connection ID by referencing the value of self.conn_name_attr.

It's important to document these things well to prevent potential bugs.


I noticed you had already investigated and added similar cases like this one, so I'm adding this as well. Thank you!
@jscheffl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants