Cleanup type ignores in vertica provider where possible#53252
Merged
gopidesupavan merged 2 commits intoapache:mainfrom Jul 13, 2025
Merged
Cleanup type ignores in vertica provider where possible#53252gopidesupavan merged 2 commits intoapache:mainfrom
gopidesupavan merged 2 commits intoapache:mainfrom
Conversation
potiuk
approved these changes
Jul 12, 2025
jscheffl
commented
Jul 12, 2025
providers/vertica/src/airflow/providers/vertica/hooks/vertica.py
Outdated
Show resolved
Hide resolved
This was referenced Jul 12, 2025
112438b to
de0c217
Compare
gopidesupavan
approved these changes
Jul 13, 2025
Contributor
|
this case same case """Establish a connection to pinot broker through pinot dbapi."""
conn = self.get_connection(self.get_conn_id())get_conn_id() is a method defined in DbApiHook that dynamically returns the appropriate connection ID by referencing the value of self.conn_name_attr. It's important to document these things well to prevent potential bugs. I noticed you had already investigated and added similar cases like this one, so I'm adding this as well. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #53241